denoland / denoland/deploy_feedback

Enable LFS for cloned project in Deno build

Open
#945 0 comments 1 reaction 0 assignees View on GitHub
enhancement
Dominant language
No language data
Stars
79
Forks
5
PR merge metrics
No merged PRs in 30d

Description

### What problem are you trying to solve?

I have a couple of fonts used for my web app, that are checked in using [Git LFS](https://git-lfs.com/), to avoid binary bloat in Git. When attempting to build the site using the build command inside Deno Deploy (`deno x vite build`), the build does not produce the correct output due to missing Git LFS file binaries.

I added a small `console.log` statement to the `vite.config.ts` file to log out the size of the font, and I get `139792` locally and in GitHub actions when building with Vite, but get only `131` inside the build on Deno Deploy.

```ts
import { statSync } from 'node:fs';
import { defineConfig } from 'vite';

console.log('Fonts siz:', statSync('src/fonts/Rosario.ttf').size);
// "Font size: 139792"
// "Font size: 131" (Inside Deploy)

export default defineConfig({ ... });
```

### Describe the solution you'd like

I would like Deno Deploy to just work with Git LFS, since I believe it common for websites to use binary files (fonts, audio, video).

### Describe alternatives you've considered

The only workaround I see is using GitHub actions to build, then deploy via `deno deploy` command.

### Documentation, Adoption, Migration Strategy

_No response_

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the `deno x vite build` command inside Deno Deploy and compare it with the local or GitHub Actions build. Inspect `vite.config.ts` and `src/fonts/Rosario.ttf`; done means the deployed build reads the full Git LFS binary instead of the 131-byte pointer file.

Written by the indexing model from the issue text.

Assessment

Tech stack
deno, git, vite
Domain
build-system, cloud
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.