denoland / denoland/deploy_feedback

[Bug]: [UX] some Web Dialogs are closed by mouse-up outside the dialog

Open
#942 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
79
Forks
5
PR merge metrics
No merged PRs in 30d

Description

### Problem description

When selecting text within a dialog - for example the "Add Member" Dialog to add members in organizations - I usually start selecting text and drag the mouse over the border of the dialog.

When the Mouse is released outside the Dialog, the mouseup event fires - closing the dialog.

### Steps to reproduce

1. Open any Dialog, for example the Add Member Dialog within the organization settings
2. start clicking and dragging mouse (for example to select some text) from inside the dialog over the edge of the dialog
3. release the mouse outside of the dialog

### Expected behavior

Dialog stays open, text is selected. (e.g within an input field)

### Environment

Deno Deploy Console Website

### Possible solution

Change eventhandler from `mouseup` to `mousedown` or `click` to only run the "close dialog" when the user explicitly clicks outside the dialog.

### Additional context

I did only confirm this for the "Invite Users" dialog within organization settings.
Image

Other options like "Add Environment Variables", which open in a sidebar and not in a dialog, do not have this bug.

But there may be other dialogs which have this bug, as it is probably a shared codebase.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.