denoland / denoland/deploy_feedback
[Bug]: npm package `cli-spinners@3.2.0` contains json file that causes boot failure
- Dominant language
- No language data
- Stars
- 79
- Forks
- 5
- PR merge metrics
- No merged PRs in 30d
Description
### Problem description
When trying to deploy a project that uses `npm:cli-spinners@3.2.0`, like an ssh app using `inkjs`, a `BOOT_FAILURE` error is thrown at the very end of deployment as shown below:
```sh
$ deployctl deploy
Cℹ Using config file 'clispinnersbug-deno/deno.json'
C⚠ No project name or ID provided with either the --project arg or a config file.
C✔ Guessed project name 'clispinnersbug-deno'.
ℹ You can always change the project name with 'deployctl projects rename new-name' or in https://dash.deno.com/projects/clispinnersbug-deno/settings
C⚠ No entrypoint provided with either the --entrypoint arg or a config file. I've guessed 'main.ts' for you.
ℹ Is this wrong? Please let us know in https://github.com/denoland/deployctl/issues/new
C✔ Deploying to project clispinnersbug-deno.
ℹ The project does not have a deployment yet. Automatically pushing initial deployment to production (use --prod for further updates).
C✔ Entrypoint: ./clispinnersbug-deno/main.ts
Cℹ Uploading all files from the current dir (./clispinnersbug-deno)
C✔ Found 4 assets.
C✔ Uploaded 4 new assets.
C✖ Deployment failed.
error: The deployment failed: BOOT_FAILURE
Expected ';', '}' or at file:///node_modules/.deno/cli-spinners@3.2.0/node_modules/cli-spinners/spinners.json:2:9
"dots": {
~
```
basic example that triggers the bug on deployment:
```js
import spinners from "npm:cli-spinners";
console.log(spinners.dots);
```
### Steps to reproduce
1. `mkdir spinnerbug`
2. `deno init`
3. `echo 'import spinners from "npm:cli-spinners";\nconsole.log(spinners.dots);\n' > main.ts
4. `deno run main.ts` - works no problem
5. `deployctl deploy` - fails here
### Expected behavior
The app should deploy without issue, especially because `cli-spinners` appears to use the newer `with {"type": "json"}` import syntax.
### Environment
- Deno version 2.4.0 (also tested with 2.4.2)
```
deno 2.4.0 (stable, release, aarch64-apple-darwin)
v8 13.7.152.6-rusty
typescript 5.8.3
```
- deployctl 1.13.1
- OS info:
```
System Version: macOS 15.3.2 (24D81)
Kernel Version: Darwin 24.3.0
System type: Apple MacBook M1 Pro
```
### Possible solution
_No response_
### Additional context
I have tested this locally and confirmed at least on my Mac the issue is replicable. I have not tested it on a linux machine yet though.
I have cleared my cache, reinstalled Deno and DeployCTL and the issue persists. Have also deleted `node_modules` folder to no avail.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.