denoland / denoland/deploy_feedback

Bug: Node JS being installed in the workflow even when it's not needed

Open
#861 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
79
Forks
5
PR merge metrics
No merged PRs in 30d

Description

I have used Deno Deploy for two projects now: one Solid Start project and one regular Deno API project with a single NPM dependency, and both times Deno Deploy added a GH workflow to my repo with a Node JS installation step. I was confused by this, as Node wasn't required in either case, and when I removed that step from the workflow, it worked exactly the same, no issues at all. It would be best for Deno Deploy to avoid installing Node JS when it's not needed. Here's one example of this issue: https://github.com/mintydev789/justfuckingusehttp.com/commit/42b61530d0b3cdc1d1d30a5ff82f2b7524a0a5b3

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.