denoland / denoland/deploy_feedback

[Bug]: deployctl deploy does not honor include/exclude directives

Open
#647 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
79
Forks
5
PR merge metrics
No merged PRs in 30d

Description

### Problem description

I have the following workspace:

image

And the following deno.json setup:

```json
{
"deploy": {
"project": "33c4929e-bd0e-419e-b0fd-5c1f230dde58",
"exclude": [
"**/node_modules"
],
"include": [
"./build"
],
"entrypoint": "https://deno.land/std@0.221.0/http/file_server.ts"
}
}
```

However, after `deployctl deploy`, it uploads all directories in the root of my workspace (but not files?), and when I launch the site via Deploy, I get:

image

As you can see, the `include` and `exclude` directives in my deno.json were ignored. I've also tried using `"./build/**"` and removing the exclude (since there is no node_modules inside the build folder). Same result.

### Steps to reproduce

1. Run `deployctl deploy --include="./build"` on a project which has a number of folders, including one called build.

### Expected behavior

Only the build folder would be uploaded.

### Environment

Deno 1.42.1
deployctl v1.12.0

### Possible solution

_No response_

### Additional context

_No response_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.