denoland / denoland/deploy_feedback
[KV Feedback]: improve Deno.KvCommitError message
- Dominant language
- No language data
- Stars
- 79
- Forks
- 5
- PR merge metrics
- No merged PRs in 30d
Description
### 🔍
- [x] Did you search for existing issues?
### Type of feedback
General feedback
### Description
I have a case where `delete()` atomic operator returns `{ok:true}` when deleting non-exist keys. This behavior confused me for half of a day because I thought it would return `{ok:false}` if key not found.
### Steps to reproduce (if applicable)
- use Deno playground to test DenoKV
- delete the any non-exist/wrong type key
### Expected behavior (if applicable)
Return `{ok:false}`
### Possible solution (if applicable)
I think it would be better if we replace `ok` property with `{status: int}`. We can implement the [SQLite response code system](https://www.sqlite.org/rescode.html) for case. It can offer a better debugging experience.
### Additional context
_No response_
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.