denoland / denoland/deploy_feedback

[Bug]: Deploy preview based upon branch name has a case sensitive URL

Open
#423 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
No language data
Stars
79
Forks
5
PR merge metrics
No merged PRs in 30d

Description

### Problem description

The URL address created from the branch name on deploy preview is case sensitive.

Some browsers (google chrome / firefox) doesn't behave well when the case sensitive char is on the host name.

When accessing that URL, my browser will lower case it and I will receive a 404 - DEPLOYMENT_NOT_FOUND message.

### Steps to reproduce

1. Create a branch with some uppercase (ex.: newFeature)
2. Access your deploy preview based upon that branch name

### Expected behavior

I expect the correct preview from that branch to be displayed.

### Environment

- Firefox 114.0.2 Mozilla Snap for Ubuntu
- Google Chrome Version 114.0.5735.133 (Official Build) (64-bit)

### Possible solution

Lower case the branch name before creating preview URL address.

### Additional context

_No response_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.