denoland / denoland/deploy_feedback

[Bug]: websocket server connections close too quickly after switching from manual to automatic certs

Open
#387 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
79
Forks
5
PR merge metrics
No merged PRs in 30d

Description

### Problem description

I have had a simple chat-like webscoket client-sever app deployed on Deno Deploy where the client successfully uses keep-alives (every 10 seconds) to keep the socket connection open for the duration of the session. This was set up with manually uploaded certificates and has worked great for the past week or longer. This morning I switched the certs to use automatic certs from Deno, and immediately after the change the production app could no longer hold a connection open for more than minutes, with the socket being closed on the client by the server. No code changes were pushed before or after this cert change so it's the only proximate cause I can guess. Is this behavior known or expected? I am currently attempting to revert to our manual certs to see if this restores the original behavior.

### Steps to reproduce

1. deploy a websocket chat demo-like app to Deno Deploy with client-side keep-alives and set up manual certs - should observe clients don't get disconnected by server at least for hours
2. update cert to automatic certs from Deno
3. should observe clients get disconnected by server in minutes or seconds after connecting

Note: I have not tried to reproduce the above from scratch with a new app, just summarizing what happened in our case.

### Expected behavior

Updating to automatic certs from Deno should not change the behavior of a previously functional deployed app with valid manual certs.

### Environment

_No response_

### Possible solution

_No response_

### Additional context

_No response_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.