denoland / denoland/deno_graph

Use byte indexes instead of lines and columns

Open
#79 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
137
Forks
47
Avg merge
2d 7h
Merged PRs (30d)
4

Description

> I think lines and columns is an LSP & display concern and we should remove it from deno_graph. I think deno_graph should just return byte indexes or at least have both. It would also be good to standardize any unit types with deno_ast (so probably just use swc's Span for ranges... or maybe we could make our own type that uses usize and easily converts to an swc span)

[discussion_r767983595](https://github.com/denoland/deno/pull/13074#discussion_r767983595)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the linked discussion and inspect deno_graph's existing line-and-column range APIs. Compare their unit types with deno_ast and swc's Span, then clarify which representation the project should standardize on. Done means the agreed range representation is consistently exposed by deno_graph and its callers are updated.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.