denoland / denoland/deno_graph

Ability to discern between types directive and x-TypeScript-types

Open
#133 2 comments 0 reactions 1 assignee Claimed by @kitsonk View on GitHub
enhancement
Dominant language
Rust
Stars
137
Forks
47
Avg merge
2d 7h
Merged PRs (30d)
4

Description

For `deno vendor`, it might be nice to have a way to represent `/// ` and `x-TypeScript-types` separately in the graph while still providing a common method for the `maybe_types_dependency`.

This would also help us remove `Range` from being necessary for `x-typescript-types` as the types directive could have a range, but the `x-typescript-types` doesn't need one:

https://github.com/denoland/deno_graph/blob/f8adbe45ab39a52ec2bbcb671a65593acf072226/src/graph.rs#L1331-L1340

Alternatively, I can just do a check for the start and end position all being zero, but that seems a little hacky.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.