denodrivers / denodrivers/postgres

suggestion: make loading config from env optional

Open
#418 1 comment 1 reaction 0 assignees View on GitHub
good first issue
Dominant language
TypeScript
Stars
655
Forks
97
PR merge metrics
No merged PRs in 30d

Description

When I add the project as a dependency, it'll require env var access for `PGAPPNAME`, `PGDATABASE`, `PGHOST`, `PGOPTIONS`, `PGPASSWORD`, `PGPORT`, `PGUSER` regardless I prefer to use this way of providing configuration or not. I consider allowing access to all env vars via `--allow-env` as a security risk and runnig with `--allow-env=PGAPPNAME,PGDATABASE,PGHOST,PGOPTIONS,PGPASSWORD,PGPORT,PGUSER` is pretty unconvinient.

So WDYT about considering a way to opt-out from auto-config via env vars?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.