denodrivers / denodrivers/postgres

Generate testing certificates as part of the docker database initialization

Open
#326 3 comments 0 reactions 1 assignee Claimed by @Soremwar View on GitHub
enhancement
Dominant language
TypeScript
Stars
655
Forks
97
PR merge metrics
No merged PRs in 30d

Description

My only concern with #308 is that the current testing workflow requires the contributors to manually run a script to generate the required certificates, instead of abstracting away that configuration as part of the normal docker initialization

This might require stepping away from using the official docker image of postgres and building one of our own due to the following reasons:
- We require the generated certificate to be available on the host file system to make it accessible from the tests, however docker volumes are not writable without the proper permissions. So it would be removing the need to run one command in the CLI to run another
- We need persistance of the certificates so when the database containers are run from cache the certificates are still available to be used by the driver, this might require moving the certificates to a different location that can reflect live changes to them, instead of copying them inside the container after being generated

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.