dennisdoomen / dennisdoomen/CSharpGuidelines

Relax AV1555 so that named parameters are permitted when invoking external libraries

Open
#276 6 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
777
Forks
270
PR merge metrics
No merged PRs in 30d

Description

The following use of named parameters when invoking `AddApplicationInsights` should be allowed by [AV1555](https://github.com/dennisdoomen/CSharpGuidelines/blob/master/_rules/1555.md)

```
builder.Services.AddLogging(loggingBuilder =>
{
if (!string.IsNullOrWhiteSpace(connectionString))
{
// Enable logging to the Application Insights service.
loggingBuilder.AddApplicationInsights(
configureTelemetryConfiguration: config => config.ConnectionString = connectionString,
configureApplicationInsightsLoggerOptions: options => { }
);
}
});
```

Whether that external library is a package build by the same developer isn't relevant.

See also discussion https://github.com/bkoelman/CSharpGuidelinesAnalyzer/issues/145

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.