demml / demml/scouter

`create_data_profile` options unneeded

Open
#170 0 comments 0 reactions 0 assignees View on GitHub
good first issue
Dominant language
Rust
Stars
13
Forks
1
PR merge metrics
No merged PRs in 30d

Description

```rust
#[pyo3(signature = (data, data_type=None, bin_size=20, compute_correlations=false))]
#[instrument(skip_all)]
pub fn create_data_profile<'py>(
&mut self,
py: Python<'py>,
data: &Bound<'py, PyAny>,
data_type: Option<&DataType>,
bin_size: Option,
compute_correlations: Option,
) -> Result {
```

should be

```rust
#[pyo3(signature = (data, data_type=None, bin_size=20, compute_correlations=false))]
#[instrument(skip_all)]
pub fn create_data_profile<'py>(
&mut self,
py: Python<'py>,
data: &Bound<'py, PyAny>,
data_type: Option<&DataType>,
bin_size: usize,
compute_correlations: bool,
) -> Result {
```

there's not need for option here since the pyo3 signature already specifies defaults

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.