`create_data_profile` options unneeded
- Dominant language
- Rust
- Stars
- 13
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
```rust
#[pyo3(signature = (data, data_type=None, bin_size=20, compute_correlations=false))]
#[instrument(skip_all)]
pub fn create_data_profile<'py>(
&mut self,
py: Python<'py>,
data: &Bound<'py, PyAny>,
data_type: Option<&DataType>,
bin_size: Option,
compute_correlations: Option,
) -> Result {
```
should be
```rust
#[pyo3(signature = (data, data_type=None, bin_size=20, compute_correlations=false))]
#[instrument(skip_all)]
pub fn create_data_profile<'py>(
&mut self,
py: Python<'py>,
data: &Bound<'py, PyAny>,
data_type: Option<&DataType>,
bin_size: usize,
compute_correlations: bool,
) -> Result {
```
there's not need for option here since the pyo3 signature already specifies defaults
Contributor guide
Assessment
This issue has not been assessed yet.