deltadevsde / deltadevsde/prism

improvement: avoid doubly storing vk for Proofs

Open
#182 0 comments 0 reactions 1 assignee Claimed by @distractedm1nd View on GitHub
p2 zk optimization
Dominant language
Rust
Stars
134
Forks
41
PR merge metrics
No merged PRs in 30d

Description

After the Account refactor, we now pass the vk in the `Transaction`. As this is also stored in the `Account`, it gets serialized twice inside of InsertProof/UpdateProof.

We could use key_idx like we did previously, but this should be done in a way that has a nice UX.

I am leaving it as an additional issue because this is an optimization that could damage UX and readability if we don't do it in a nice way.

_Originally posted by @distractedm1nd in https://github.com/deltadevsde/prism/pull/180#discussion_r1889952673_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.