dell / dell/omsdk

Untracked Dependancy on pywinrm

Open
#36 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
63
Forks
22
PR merge metrics
No merged PRs in 30d

Description

# QwikContext
`omsdk.http.sdkwmi` requires `winrm` to function, but it is not in `requirements.txt`

# Details
`omsdk.http.sdkwmi` imports functions from the `winrm` module, but this dependency is not expressed anywhere. That means that anyone installing this module from PyPi will get an error if they try and use that class. Given that Ansible also uses `pywinrm` (), I'm guessing that this was missed by accident as it was already installed.

# Repro Steps
1. `pip install omsdk`
2. Import `omsdk.http.sdkwmi` in a Python file.

```
Traceback (most recent call last):
File "", line 1, in
File "/usr/local/lib/python3.12/site-packages/omsdk/http/sdkwmi.py", line 25, in
from winrm.transport import Transport
ModuleNotFoundError: No module named 'winrm'
```

# Impact
Error when using `omsdk.http.sdkwmi` until user manually runs `pip install pywinrm`.

# NeedBy
Whenever convenient.

# Severity
Low.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.