dell / dell/libsmbios

Kernel interface for battery controls

Open
#84 10 comments 4 reactions 0 assignees View on GitHub
Dominant language
C
Stars
221
Forks
42
PR merge metrics
No merged PRs in 30d

Description

Are there any plans to add support for interacting with the battery controls in the Dell kernel driver (analog to the [implementation in libsmbios](https://github.com/dell/libsmbios/commit/0eab0085e8f0db3c2a0f8ae0146d3352c40d785a), just in the kernel)?

As I have outlined already in an issue for the [TLP utility](https://github.com/linrunner/TLP) (https://github.com/linrunner/TLP/issues/321#issuecomment-575653531 and https://github.com/linrunner/TLP/issues/321#issuecomment-576059832), Google has introduced a set of new sysfs attributes and infrastructure that makes it fairly easy to implement extended controls for power supplies, and in particular batteries (for details see [Documentation/ABI/testing/sysfs-class-power](https://github.com/torvalds/linux/blob/26dca6dbd62d74a5012cafab6b2d6d65a01ea69c/Documentation/ABI/testing/sysfs-class-power#L156) and [drivers/power/supply/power_supply_sysfs.c](https://github.com/torvalds/linux/blob/26dca6dbd62d74a5012cafab6b2d6d65a01ea69c/drivers/power/supply/power_supply_sysfs.c#L239)).

This appears to be primarily aimed at their new Embedded Controller (Wilco EC) on the chromebook platform ([drivers/power/supply/wilco-charger.c](https://github.com/torvalds/linux/blob/26dca6dbd62d74a5012cafab6b2d6d65a01ea69c/drivers/power/supply/wilco-charger.c) and [Documentation/ABI/testing/sysfs-class-power-wilco](https://github.com/torvalds/linux/blob/26dca6dbd62d74a5012cafab6b2d6d65a01ea69c/Documentation/ABI/testing/sysfs-class-power-wilco)), but in particular the [charge modes](https://github.com/torvalds/linux/blob/26dca6dbd62d74a5012cafab6b2d6d65a01ea69c/drivers/power/supply/wilco-charger.c#L24) and [battery charging threshold settings in custom mode](https://github.com/torvalds/linux/blob/26dca6dbd62d74a5012cafab6b2d6d65a01ea69c/drivers/power/supply/wilco-charger.c#L118) of the Wilco EC map directly to the ones found in [Dell laptops](https://github.com/dell/libsmbios/commit/0eab0085e8f0db3c2a0f8ae0146d3352c40d785a#diff-edb5764dc20eb3b3ec617b1bf3cce546R113).

Support for [Huawei](https://github.com/torvalds/linux/commit/355a070b09ab1f29f36447c91cde3e6fd07775e0) and [Asus](https://github.com/torvalds/linux/commit/7973353e92ee1e7ca3b2eb361a4b7cb66c92abee) laptops to use this new sysfs interface has also been implemented, and the [Lenovo](https://sourceforge.net/p/ibm-acpi/mailman/message/36911999/) driver may also be ported over soon.

Last, if there is a better place to report feature request for the Dell laptop driver in the Linux kernel, I would appreciate if someone could direct to the right place/forum for that.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.