dell / dell/libsmbios

Cleanups requested from Ubuntu security review

Open
#43 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
221
Forks
42
PR merge metrics
No merged PRs in 30d

Description

Some of these aren't applicable since C++ API was dropped, but they should all be reviewed and decisions made. Removing the factories may be problematic as they're used in other consumers of libsmbios (such as fwupd).

These came from: https://bugs.launchpad.net/ubuntu/+source/libsmbios/+bug/1603072/comments/14

- [ ] compile with UBSAN and make sure it's clean
- [ ] compile with ASAN and make sure it's clean
- [ ] fix the readByteArray() / writeByteArray() to work on more than one byte
at a time
- [ ] replace auto_ptr with the correct replacements at each use
- [ ] remove the factories altogether
- [ ] refactor copy_mmap() / trycopy() / remap()
- [ ] try afl-fuzz on the different tools

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.