delight-im / delight-im/PHP-Auth
Missing "InvalidEmailException" for "resendConfirmationForEmail"
- Dominant language
- PHP
- Stars
- 1.2k
- Forks
- 236
- PR merge metrics
- No merged PRs in 30d
Description
First of all, thank you for your wonderful work and the great library.
I have two suggestions which I will handle in two requests.
1.) Missing "InvalidEmailException" for "resendConfirmationForEmail":
For consistency reasons the method "resendConfirmationForEmail" should check the validity of the email as the other methods that deal with emails do.
Contributor guide
No contributing guide indexed for this repository
Research direction
Locate the resendConfirmationForEmail method and compare its email validation with the other email-related methods. Check how InvalidEmailException is raised elsewhere, then verify that invalid email input to resendConfirmationForEmail produces the same exception while valid input keeps its existing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- authentication, security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100