delight-im / delight-im/Android-DDP

mReconnectAttempts issue

Open
#62 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Java
Stars
274
Forks
51
PR merge metrics
No merged PRs in 30d

Description

Method onClose (Meteor.java 148). I think mReconnectsAttempts can't be more than 1. Because we increase this one only if lostConnection == true, and lostConnection is true only after we do mConnected = true, but we do mConnected = true only in one place - onOpen() (Meteor.java 140), where we also do mReconnectAttempts = 0.

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect Meteor.java around onOpen() at line 140 and onClose() at line 148, tracing the assignments to mConnected, lostConnection, and mReconnectAttempts. Verify whether the counter can exceed one, then confirm the intended behavior with a focused regression test or equivalent check; done means the counter behavior is demonstrated and corrected if necessary.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
mobile-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.