dekatotoro / dekatotoro/SlideMenuControllerSwift

Retain cycle

Open
#384 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
Swift
Stars
3.4k
Forks
742
PR merge metrics
No merged PRs in 30d

Description

There is a retain cycle in SlideMenuController.swift

Use weak or unowned to fix it.

Here the solution:

![screen shot 2018-05-17 at 09 46 24](https://user-images.githubusercontent.com/738681/40166785-5595c0e0-59b7-11e8-8bb5-68edd958387f.png)

Contributor guide

No contributing guide indexed for this repository

Research direction

Open SlideMenuController.swift and inspect the retain-cycle location indicated by the issue and its screenshot. Confirm which ownership reference keeps the cycle alive, then verify that the controller no longer retains the cycle while preserving the existing iOS slide-menu behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.