dekatotoro / dekatotoro/SlideMenuControllerSwift

BUG SlideMenu + TabBar, TabItem are not visible

Open
#262 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
3.4k
Forks
742
PR merge metrics
No merged PRs in 30d

Description

Hi,

First thanks for your POD, awesome work
I found an issue when I try to add the SlideMenu in a TabBar.

You can test it with the following code (your code updated) :

let mainViewController = storyboard.instantiateViewController(withIdentifier: "MainViewController") as! MainViewController
let leftViewController = storyboard.instantiateViewController(withIdentifier: "LeftViewController") as! LeftViewController

let rightViewController = storyboard.instantiateViewController(withIdentifier: "RightViewController") as! RightViewController

let slideMenuController = SlideMenuController(mainViewController: mainViewController, leftMenuViewController: leftViewController)

let tabBarController = UITabBarController()
tabBarController.viewControllers = [slideMenuController]
self.window?.rootViewController = tabBarController
self.window?.makeKeyAndVisible()`

You would see the TabBar like this :

capture d ecran 2016-12-16 a 15 48 58

In normal case, if you add a simple view controller, for example in previous code :

`tabBarController.viewControllers = [mainViewController]`

You would see the TabBar like this :

capture d ecran 2016-12-16 a 15 49 21

This "gray subview" hide TabBarItem, any idea ?

Thanks

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the provided SlideMenuController and UITabBarController reproduction, comparing it with the direct mainViewController case. Inspect how the SlideMenuController is embedded and how its gray subview is laid out relative to the tab bar. Done means the TabBarItem remains visible when SlideMenuController is used as a tab bar controller child.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, swift
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.