deis / deis/workflow-cli

Extract common Jenkinsfile logic into Pipeline Global Library

Open
#142 3 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Go
Stars
31
Forks
42
PR merge metrics
No merged PRs in 30d

Description

This repo's [Jenkinsfile](https://github.com/deis/workflow-cli/blob/master/Jenkinsfile) as well as the [controller-sdk-go](https://github.com/deis/controller-sdk-go) repo's [Jenkinsfile](https://github.com/deis/controller-sdk-go/blob/master/Jenkinsfile) share common logic, especially as of https://github.com/deis/controller-sdk-go/pull/46 which builds workflow-cli in place, duplicating many steps used in this repo's pipeline.

It would be preferable if we extracted shared logic into common functionality via the [Pipeline Global Library](https://github.com/jenkinsci/workflow-cps-global-lib-plugin/blob/master/README.md#pipeline-global-library) to both reduce duplication and enable only making changes to such functionality in one location. Some functionality will even prove to be generally useful outside of workflow-cli/controller-sdk-go's scope, such as [sending email notifications on e2e failures](https://github.com/deis/workflow-cli/pull/133).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.