deis / deis/steward-framework

Fix delete instance event handler

Open
#56 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
6
Forks
3
PR merge metrics
No merged PRs in 30d

Description

When an `Instance` is deleted, `handleDeleteInstance` is called. It doesn't decode the event's object correctly, and the following error is omitted:

```console
00:31:40 DEBUG framework.k8s.instance loop.go:45 instance loop received event
00:31:40 ERROR framework.k8s.instance loop.go:70 delete instance event handler failed (not an instance)
```

In its current state, the handler should match the same decoding logic as in `handleAddInstance`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.