deis / deis/jenkins-node

Refactor: Reduce custom logic

Open
#10 1 comment 0 reactions 0 assignees View on GitHub
refactor
Dominant language
Shell
Stars
5
Forks
8
PR merge metrics
No merged PRs in 30d

Description

https://github.com/deis/jenkins-node/pull/9 updates the jenkins-node image to act more like a default Jenkins [jnlp-slave](https://github.com/jenkinsci/docker-jnlp-slave). However, due to how e2e is setup to run (see [deis/e2e-runner](https://github.com/deis/e2e-runner)), we still have some custom logic in the `Dockerfile` and `jenkins-slave` script.

Therefore, this ticket is to make updates (most likely necessary both in this and the aforementioned e2e-runner repo) to switch up the `Dockerfile` to pull from `jenkinsci/jnlp-slave` as well as removing our version of the script (delete the `rootfs` dir).

Contributor guide

Open the contributing guide

Research direction

Start with the Dockerfile and the jenkins-slave script, then review how e2e-runner sets up the image. Compare the current image with jenkinsci/jnlp-slave and determine the required changes across both repositories. Done means the Dockerfile pulls from jenkinsci/jnlp-slave and the custom rootfs directory and script are removed without breaking the e2e setup.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, shell
Domain
ci-cd
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.