deis / deis/dockerbuilder

Do not inject ARG on newer Docker versions.

Open
#123 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
17
Forks
27
PR merge metrics
No merged PRs in 30d

Description

https://github.com/deis/dockerbuilder/pull/118/files/13b2463d5311da00ac5125534ee7add19a89fa3a#r108909997

I think it might be a good idea to not inject the ARGs in newer Docker versions. For me, each ARG statement takes about 2 seconds to run (Running on Azure). With a bunch of config vars defined, this extends the build time by minutes for me.

As an aside I do wonder why the ARG takes so long when running on my Deis install. Building the Dockerfile directly is super fast. Is this a disk-bound operation?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.