deis / deis/builder

Builder fails to cleanup object store slugs

Open
#494 3 comments 3 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
40
Forks
41
PR merge metrics
No merged PRs in 30d

Description

Destroying an app via Deis cli does not clean up the build slugs when app name fails to match regex.

Builder Version: 2.7.1
Storage Driver: Swift
Steps to reproduce:
`deis destroy --app=my-app`
`kubectl logs BUILDER --namespace=deis`

Only log line written is clearing the cache:
`Cleaner deleting cache home/my-app/cache for app my-app`

Missing the lines in code at #445

`log.Info("Cleaner deleting slug %s for app %s", obj, app)`

`my-app` had over 100 builds.

Issue is potentially the regex matching:

`gitRegex, err := regexp.Compile(`^/` + fmt.Sprintf(gitreceive.GitKeyPattern, app, ".{8}") + "$")`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.