deepspeedai / deepspeedai/DeepSpeedExamples
Something wrong at step1_supervised_finetuning/main.py
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 6.8k
- Forks
- 1.1k
- Avg merge
- 2d 16h
- Merged PRs (30d)
- 1
Description
this line
losses += loss.float()
will accumulate grad and result in OOM
I think maybe change to this:
losses += loss.detach().cpu()
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect applications/DeepSpeed-Chat/training/step1_supervised_finetuning/main.py at line 299 and start by tracing how loss is accumulated during supervised fine-tuning. Reproduce or review the memory behavior around the accumulation, then verify that the reported loss no longer retains gradients or causes out-of-memory growth.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100