deepspeedai / deepspeedai/DeepSpeedExamples
[BUG] Evaluation sampler is assigned incorrectly in `step_2_reward_model_finetuning`
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 6.8k
- Forks
- 1.1k
- Avg merge
- 2d 16h
- Merged PRs (30d)
- 1
Description
Hi there,
I notice that the following line seems to be redundant and will disable the distributed eval sampler in line 242.
Therefore, in multi-gpus setting, all gpu will go through the same data and this wastes a lot of computation.
Thanks.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open applications/DeepSpeed-Chat/training/step2_reward_model_finetuning/main.py around lines 242 and 247 and trace how the evaluation sampler is assigned. Check the multi-GPU evaluation path to confirm whether each GPU receives distinct data. Done means the distributed evaluation sampler remains active and the redundant assignment no longer causes duplicated evaluation work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- distributed-systems, machine-learning
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100