deepspeedai / deepspeedai/DeepSpeedExamples
ds_eval_config v.s. ds_config
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 6.8k
- Forks
- 1.1k
- Avg merge
- 2d 16h
- Merged PRs (30d)
- 1
Description
when initializing reward and ref models in step 3 of deepspeed-chat, there are two kinds of deepspeed config files are used, i.e. ds_config and ds_eval_config. May I ask why we need to use two configs here and any suggestions on safely removing ds_eval_config? e.g.,
def _init_reward(self, critic_model_name_or_path):
stime = log_init("Reward")
# DS Config
zero_stage = self.args.critic_zero_stage
if zero_stage != 3:
# If critic is ZeRO-3 then we use it for everything, otherwise assume we have enough memory
zero_stage = 0
ds_config = get_eval_ds_config(offload=self.args.offload,
stage=zero_stage)
ds_config[
'train_micro_batch_size_per_gpu'] = self.args.per_device_mini_train_batch_size
ds_config[
'train_batch_size'] = self.args.per_device_mini_train_batch_size * torch.distributed.get_world_size(
) * self.args.gradient_accumulation_steps
#TODO(jeff): should not be needed, we should be able to use ds_config above
#TODO(jeff): it means we never create the critic w. zero.init context if we are using ZeRO-3
ds_eval_config = get_eval_ds_config(offload=False, stage=0)
# Model
reward_model = create_critic_model(
model_name_or_path=critic_model_name_or_path,
tokenizer=self.tokenizer,
ds_config=ds_eval_config,
num_padding_at_beginning=self.args.num_padding_at_beginning,
rlhf_training=True)
reward_engine, *_ = deepspeed.initialize(model=reward_model,
config=ds_config)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the step 3 deepspeed-chat flow at _init_reward and trace get_eval_ds_config, create_critic_model, and deepspeed.initialize. Compare the roles of ds_config and ds_eval_config, then verify whether removing the second configuration preserves reward-model initialization and ZeRO behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100