deepspeedai / deepspeedai/DeepSpeedExamples

Megatron-LM-v1.1.5-ZeRO-2/3 doesn't support model change to Huggingface Bert

Open
#104 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
6.8k
Forks
1.1k
Avg merge
2d 16h
Merged PRs (30d)
1

Description

I try to replace megatron bert model to huggingface bert model in model_provider function.

However, the program can't pass deepspeed/runtime/zero/stage3.py:1896

assert self.params_already_reduced[param_id] == False,
f"The parameter {param_id} has already been reduced.
Gradient computed twice for this partition.
Multiple gradient reduction is currently not supported"

AssertionError: The parameter 102 has already been reduced. Gradient computed twice for this partition. Multiple gradient reduction is currently not supported

The parameter 102 is embedding weights, any suggestions?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the model_provider function and reproduce the failure when replacing the Megatron BERT model with the Hugging Face BERT model. Inspect deepspeed/runtime/zero/stage3.py at line 1896 and trace the embedding-weight parameter involved; done means ZeRO-2/3 completes without the duplicate gradient-reduction assertion.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
distributed-systems, machine-learning
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.