deepspeedai / deepspeedai/DeepSpeed
Details about backward hooks in stage3, why detach outputs?
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 43.1k
- Forks
- 5k
- Avg merge
- 4d 15h
- Merged PRs (30d)
- 112
Description
Dear authors,
Thank you for the awesome works. I try to learn some implementation details and come across a small question.
I doubt the meaning of the two following lines. I believe it is the same if you remove two lines and in this way, you may save some tmp memory.
https://github.com/microsoft/DeepSpeed/blob/master/deepspeed/runtime/zero/stage3.py#L503
https://github.com/microsoft/DeepSpeed/blob/master/deepspeed/runtime/zero/stage3.py#L528
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the linked lines in deepspeed/runtime/zero/stage3.py, especially the backward-hook handling around lines 503 and 528. Trace how the detached outputs are used and compare the behavior with those lines removed; done means establishing whether removing them preserves behavior and documenting the conclusion.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- distributed-systems, machine-learning
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100