deepspeedai / deepspeedai/DeepSpeed
[BUG] Do not silently ignore use_shared_prefill with continuous batching
@modelpath-dev is already working on this.
Since Sep 17, 2026.
- Dominant language
- Python
- Stars
- 43.1k
- Forks
- 5k
- Avg merge
- 4d 15h
- Merged PRs (30d)
- 112
Description
Context
HybridEngineRollout supports both shared prompt prefill and continuous
batching, but their interaction is currently undefined.
When continuous batching is enabled through
SamplingConfig.continuous_batch_size, the continuous path is selected before
the shared-prefill logic. As a result, HybridEngineRolloutConfig.use_shared_prefill
is silently ignored.
Continuous batching currently requires n_samples_per_prompt=1, so shared
prefill does not provide a clear benefit in this mode. However, silently
ignoring the configuration can be confusing and may hide an invalid combination
of options.
Proposed work
Define and document the behavior of use_shared_prefill when continuous
batching is enabled.
Possible choices include:
- explicitly reject the combination with a clear
ValueError; or - define and implement compatible shared-prefill semantics for continuous
batching.
Acceptance criteria
- The interaction between
use_shared_prefilland continuous batching is
explicitly defined. - The configuration is not silently ignored.
- Tests cover both compatible and incompatible configurations.
- The default non-continuous generation path remains unchanged.
Follow-up from DeepSpeed PR #8368. cc @delock
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.