deepspeedai / deepspeedai/DeepSpeed
[REQUEST] Add optional "subsequence overlap" to UlyssesSPDataLoaderAdapter
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 43.1k
- Forks
- 5k
- Avg merge
- 4d 15h
- Merged PRs (30d)
- 112
Description
For sequence parallel pipelines that have conv + downsampling layers prior to attention layers, it would be beneficial to allow for some overlap between subsequences sharded across GPUs, so as to not introduce convolution artifacts from zero-padded tensors.
I would like to see an argument I can provide to a DeepSpeed config file, like sequence_parallel_subsequence_overlap (or something less verbose), which is piped to UlyssesSPDataLoaderAdapter if present and used to adjust the sequence length for each micro-batch.
It could look something along the lines of:
class UlyssesSPDataLoaderAdapter:
def __init__(
self,
dl: DataLoader,
sp_rank: int,
sp_group,
sp_world_size,
device,
subsequence_overlap: int = 0 # <-- NEW ARG
):
...
def refill(self):
...
# update length of sharded tensor with user-defined subsequence_overlap
# specified in DS config file
chunk_len = seq_length // self.sp_world_size + subsequence_overlap
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate UlyssesSPDataLoaderAdapter and the DeepSpeed config path that supplies its arguments. Trace how each micro-batch's sequence length is calculated and determine where the optional overlap should be propagated; done means the configured value adjusts the sharded subsequence length while the default preserves current behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- distributed-systems, machine-learning
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100