deepspeedai / deepspeedai/DeepSpeed
[REQUEST] Use python sysconfig to generate CFLAGs
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 43.1k
- Forks
- 5k
- Avg merge
- 4d 15h
- Merged PRs (30d)
- 112
Description
Is your feature request related to a problem? Please describe.
In conda/venv, DeepSpeed fails to build pt_binding.o as it thinks Python.h is missing. Looking at the c++ command it's trying to use, it's not including the correct paths (/usr/include/python3.11, ~/venv/python3.11/include, etc.)
Describe the solution you'd like
Using sysconfig we can generate this, similar to what python-config.py does. Something like
flags = ['-I' + sysconfig.get_path('include'),
'-I' + sysconfig.get_path('platinclude')]
Describe alternatives you've considered
Looking at builder.py we should be able to override this with the CFLAGS, but this isn't always an option (and is an extra hoop we don't need if we let python tell us what paths to include)
Additional context
N/A
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in builder.py and reproduce the DeepSpeed build failure for pt_binding.o in a conda or virtualenv environment. Check how the C++ command currently obtains Python include paths and verify that the completed build includes the active Python include directories reported by sysconfig.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100