deepspeedai / deepspeedai/DeepSpeed

[BUG] Parameter name of `DeepSpeedCPUAdam` optimizer

Open
#3,906 1 comment 0 reactions 1 assignee View on GitHub

@loadams is already working on this.

Since Jul 10, 2023.

bug training
Dominant language
Python
Stars
43.1k
Forks
5k
Avg merge
4d 15h
Merged PRs (30d)
112

Description

Describe the bug
The name of the first parameter of DeepSpeedCPUAdam is different from that of other optimizers. It's model_params. But in the other optimizers, they are all params.
When I pass parameters with keywords, it causes trouble. I have to change the key to use DeepSpeedCPUAdam.

Expected behavior
Replace model_params with params.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.