deepspeedai / deepspeedai/DeepSpeed

[REQUEST] make ZeRO inference config more intuitive wrt `train_*` configuration

Open
#1,738 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
43.1k
Forks
5k
Avg merge
4d 15h
Merged PRs (30d)
112

Description

With the great improvements done over the last few months ZeRO can be now be easily used for inference, as in this example:
https://github.com/huggingface/transformers/issues/15399#issuecomment-1025240005
But to the user who may no longer care for training it's no longer intuitive to have these train-specific config variables:

    "train_batch_size": train_batch_size,
    "train_micro_batch_size_per_gpu": 1,

it's time to come up with a train/inference-non-specific config names and deprecate the train-specific ones.

there might be others, but these 2 just stood out.

Thank you.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the ZeRO configuration handling and references to train_batch_size and train_micro_batch_size_per_gpu. Review how configuration deprecations are tested, then define inference-neutral names, deprecation behavior for the existing names, and coverage for both training and inference configurations.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
distributed-systems, machine-learning
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.