deepset-ai / deepset-ai/haystack

Run typing checks on our test files

Open
#10,396 20 comments 0 reactions 1 assignee View on GitHub

@julian-risch is already working on this.

Since Sep 1, 2026.

P2
Dominant language
Python
Stars
26.6k
Forks
3.2k
Avg merge
1d 3h
Merged PRs (30d)
194

Description

While working on changes to haystack-experimental (https://github.com/deepset-ai/haystack-experimental/pull/430) I wanted to ensure that the protocol I was developing was working as expected with the respective implementations.

I realized though that we never actually test whether our implementations satisfy our protocols since we don't do any type checks on actual test-like code.

Therefore, I think it would be a good idea if we add type checking to our test code in our repos so we can better catch these issues. This will be quite a bit work to get our tests fully compliant but perhaps we could do it in a piece-meal approach where we only turn on type checking in a small part of tests and grow from there.

Components

  • test/components/audio/
  • test/components/builders/
  • test/components/caching/
  • test/components/classifiers/
  • test/components/connectors/
  • test/components/converters/
  • test/components/embedders/
  • test/components/evaluators/
  • test/components/extractors/
  • test/components/fetchers/
  • test/components/generators/
  • test/components/joiners/
  • test/components/preprocessors/
  • test/components/query/
  • test/components/rankers/
  • test/components/readers/
  • test/components/retrievers/
  • test/components/routers/
  • test/components/samplers/
  • test/components/tools/
  • test/components/validators/
  • test/components/websearch/
  • test/components/writers/

Document Stores

  • test/document_stores/

Agents

  • test/components/agents/

Other

  • test/core/
  • test/dataclasses/
  • test/evaluation/
  • test/fuzz/
  • test/hooks/
  • test/human_in_the_loop/
  • test/marshal/
  • test/skill_stores/
  • test/testing/
  • test/token_counters/
  • test/tools/ (top-level, distinct from test/components/tools/)
  • test/tracing/
  • test/utils/

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.