deepset-ai / deepset-ai/haystack-core-integrations
Refactor Weave integration
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 203
- Forks
- 332
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 80
Description
As reported in #2038, when working on fixing types, I discovered that currently
the Weave Tracer violates of the Liskov Substitution Principle and fixing this does not seem straightforward.
Since I'm not an expert on this integration, I can't confidently say if this is problematic or no.
(Langfuse might have similar problems but I am not sure).
We should evaluate whether this causes practical problems and if it's worth refactoring the integration to address it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read integrations/weights_and_biases_weave/src/haystack_integrations/tracing/weave/tracer.py around lines 157-159 and review issue #2038. Determine whether the reported Liskov Substitution Principle violation causes practical problems in the Weave Tracer, then assess whether refactoring is justified. Done means documenting the impact and reaching a clear refactoring decision.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- ai, observability
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100