deepset-ai / deepset-ai/haystack-core-integrations
tests requiring additional setup
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 203
- Forks
- 332
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 80
Description
Describe the bug
Mongodb Atlas tests assume specific documents, collections and databases exists
so tests in test_embedding_retrieval automaticly fail
additionally test_embedding_retrieval and test_embedding_retrieval_async are searching for MONGO_CONNECTION_STRING_2 and till be skipped. I think this is a bug and we need to to replace MONGO_CONNECTION_STRING_2 with MONGO_CONNECTION_STRING
good news I am hard at working at a pr that will ensure this database, collection, documents will be created in an idempotent manner
To Reproduce
cd
git clone https://github.com/deepset-ai/haystack-core-integrations.git
cd haystack-core-integrations/integrations/mongodb_atlas
pip install hatch
export MONGO_CONNECTION_STRING = ""
hatch run test
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in integrations/mongodb_atlas and inspect test_embedding_retrieval and test_embedding_retrieval_async, then run the integration tests with the documented MONGO_CONNECTION_STRING setup. Check how the tests select their connection and required Atlas data. Done means the required database, collection, and documents are created idempotently and the retrieval tests no longer depend on MONGO_CONNECTION_STRING_2.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- mongodb, python
- Domain
- databases, testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100