deepseek-ai / deepseek-ai/FlashMLA

Why block_size_n equals page_block_size

Open
#84 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
12.9k
Forks
1.2k
Avg merge
4h 20m
Merged PRs (30d)
2

Description

I see in flash_api.cpp, you hard code block_size_n as PAGE_BLOCK_SIZE. I dont think there is any constraint force those two variable equals.
params.block_size_n = Config::PAGE_BLOCK_SIZE;

If you simply write this equation because you only support block_size_n = 64 and page_block_size = 64, I can later push a PR to support more page_block_size (such as 1, 4, 16)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.