deepseek-ai / deepseek-ai/FlashMLA
metadata api compatibility issue
- Dominant language
- C++
- Stars
- 12.9k
- Forks
- 1.2k
- Avg merge
- 4h 20m
- Merged PRs (30d)
- 2
Description
https://github.com/deepseek-ai/FlashMLA/blob/1408756a88e52a25196b759eaf8db89d2b51b5a1/flash_mla/flash_mla_interface.py#L9
Hi, your updated metadata api change the variable name from num_heads_per_head_k to num_q_token_per_head_k, which will lead to compatibility issue, could you change the var name back or define a new python api for get_mla_metadata?
Contributor guide
No contributing guide indexed for this repository
Research direction
Start at flash_mla/flash_mla_interface.py#L9 and inspect get_mla_metadata plus its existing Python callers. Done means the previous metadata variable name remains compatible, or a separate Python API is provided without breaking users of the current interface.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100