deepmodeling / deepmodeling/tbplas

[Code scan] Make release packaging use the current checkout

Open
#24 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
19
Forks
6
PR merge metrics
No merged PRs in 30d

Description

This issue comes from a Codex global scan of deepmodeling/tbplas at commit 4d3652b3dba8eb930e4869a6d41074f62d703692.

Severity: Medium

The release checklist says to run `upload.sh`, but only `scripts/upload.sh` is tracked. That script invokes `scripts/pack.sh`, and `pack.sh` packages `$HOME/proj/tbplas` instead of the checkout from which the release command is run. This can fail on machines without that path or upload stale source from a different tree.

Code references:
https://github.com/deepmodeling/tbplas/blob/4d3652b3dba8eb930e4869a6d41074f62d703692/RELEASE.rst#L10
https://github.com/deepmodeling/tbplas/blob/4d3652b3dba8eb930e4869a6d41074f62d703692/scripts/upload.sh#L38-L44
https://github.com/deepmodeling/tbplas/blob/4d3652b3dba8eb930e4869a6d41074f62d703692/scripts/pack.sh#L4-L13

Suggested fix: document the tracked script path and derive the package source directory from the script/repository location instead of `$HOME/proj/tbplas`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.