deepmodeling / deepmodeling/dpti

[Code scan] Legacy SlurmJob module is not importable

Open
#135 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
42
Forks
27
PR merge metrics
No merged PRs in 30d

Description

Source: Codex global repository scan of deepmodeling/dpti at commit b719828e7eeb571bd26411430197cd74ea78e38c.
Project: https://github.com/orgs/deepmodeling/projects/27

Problem
The legacy `dpti.lib.SlurmJob` module imports `lib.BatchJob`, but this repository does not contain a `BatchJob.py` under `dpti/lib`, and the import is not package-qualified. The module cannot be imported in a normal package context. Its error path also references `Logger`, which is not defined in the file.

Code references
https://github.com/deepmodeling/dpti/blob/b719828e7eeb571bd26411430197cd74ea78e38c/dpti/lib/SlurmJob.py#L7
https://github.com/deepmodeling/dpti/blob/b719828e7eeb571bd26411430197cd74ea78e38c/dpti/lib/SlurmJob.py#L8
https://github.com/deepmodeling/dpti/blob/b719828e7eeb571bd26411430197cd74ea78e38c/dpti/lib/SlurmJob.py#L26

Reproduction
Run:

```bash
python -c "import dpti.lib.SlurmJob"
```

Observed result: `ModuleNotFoundError: No module named 'lib'`.

Expected result
Either remove this stale module, migrate it to the newer `RemoteJob.SlurmJob`, or make it importable with valid package-qualified dependencies.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by running `python -c "import dpti.lib.SlurmJob"` and inspect `dpti/lib/SlurmJob.py`, especially the imports and error path referenced in the issue. Compare it with the newer `RemoteJob.SlurmJob` implementation before choosing whether to remove, migrate, or repair the legacy module. Done means the selected approach is documented by tests or the import command succeeds without the reported errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
devops
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.