deepjavalibrary / deepjavalibrary/djl

Torch NDArray .max(int, boolean) should return tuple.

Open
#2,368 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Java
Stars
4.9k
Forks
759
Avg merge
16h 15m
Merged PRs (30d)
15

Description

Currently NDArray.max(int, boolean) only returns the max values. However it should also give the indexes in a tuple as per pytorch docs.

https://pytorch.org/docs/stable/generated/torch.max.html
"Returns a namedtuple (values, indices) where values is the maximum value of each row of the input tensor in the given dimension dim. And indices is the index location of each maximum value found (argmax)."

If djl's version of .max() on NDArray is intentional, please share what is the best DJL way to calculate the index of each max value. Thank you!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.