deepinsight / deepinsight/insightface
Bugs in a ArcFace implementation
Open
- Dominant language
- Python
- Stars
- 29.7k
- Forks
- 6.1k
- PR merge metrics
- No merged PRs in 30d
Description
Can somebody explain me why ArcFace class implementation was changed in this commit https://github.com/deepinsight/insightface/commit/657ae30e41fc53641a50a68694009d0530d9f6b3?
In my opinion, here are some bugs:
1) ArcFace has no_grad() in forward() which can give us wrong gradients
2) ArcFace object in forward() has no field `self.s`, instead of it has `self.scale`
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.