deep-foundation / deep-foundation/dev

Put dev package to folder which is not a parent folder for submodules

Open
#111 4 comments 2 reactions 0 assignees View on GitHub
help wanted
Dominant language
TypeScript
Stars
20
Forks
18
PR merge metrics
No merged PRs in 30d

Description

# Problem
dev package is parent for submodules and therefore its `node_modules` are shared for all of them and we can build a submodule thinking it is working as intented but without parent node_modules it will not build - for example in github modules. The same story occurs in another way. Package can be buildable in github actions but can break because of parent node_modules
Imlicitly installed packages from parent `node_modules` are misleading

## Wrong imports
Because dev is dependent on diplinks, and diplinks is its child, we can take and import in diplinks diplinks from dev dependencies.
![image](https://user-images.githubusercontent.com/66206278/226809125-8e80d761-958c-4c63-9124-e80893109fbd.png)

# How to fix it
Put dev to a dev folder which will not be a parent folder for submodules

# Note
Scripts are written for the current state of the dev repository and we should change code related to the paths in dev scripts.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.