deep-foundation / deep-foundation/deeplinks

Update PromiseOptions for `awaitPromise` function.

Open
#247 1 comment 0 reactions 1 assignee Claimed by @konard View on GitHub
enhancement question
Dominant language
TypeScript
Stars
13
Forks
8
PR merge metrics
No merged PRs in 30d

Description

https://github.com/deep-foundation/deeplinks/blob/00a1ca0ca51b3b25ba59a31ee2b4f1f410c0f55b/imports/promise.ts#L13-L21

There should be optional:
```
includePromiseIds: number[];
excludePromiseIds: number[];
```
or
```
promises : {
includeIds: number[];
execludeIds: number[];
}
```

`id` should be alias for `link_id`.

Either `link_id` or at least one included promise id should be mandatory.

Should we also make include/exclude mechanic for links, not only promises?

This or similar change is required for https://github.com/deep-foundation/npm-packager/issues/71

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.