deep-foundation / deep-foundation/deeplinks

Add `object.value._contains` for select method types

Open
#207 0 comments 1 reaction 0 assignees View on GitHub
enhancement
Dominant language
TypeScript
Stars
13
Forks
8
PR merge metrics
No merged PRs in 30d

Description

### Is your feature request related to a problem? Please describe.

When using typescript there is no autocompletion for `_contains` in `object.values`
![image](https://github.com/deep-foundation/deeplinks/assets/66206278/3e3d9706-6228-4d22-a86b-dad71338437c)
But if I use it - it works
![image](https://github.com/deep-foundation/deeplinks/assets/66206278/0a71d7c8-6e58-4ebb-86ef-3c966ef76992)
Because it is supported in gql
![image](https://github.com/deep-foundation/deeplinks/assets/66206278/145bc392-ec08-46f6-9875-14a24411705a)

### Describe the solution you'd like

Update types to contain `_contains`

### Describe alternatives you've considered

_No response_

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the TypeScript definitions for the select method types and compare them with the GraphQL support shown in the issue. Add `_contains` to the relevant type definitions, then verify that TypeScript autocomplete exposes it and the existing type checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.