deep-foundation / deep-foundation/deeplinks

Error from plv8 handler is not catchable

Open
#126 1 comment 0 reactions 0 assignees View on GitHub
bug help wanted
Dominant language
TypeScript
Stars
13
Forks
8
PR merge metrics
No merged PRs in 30d

Description

# Code
https://github.com/deep-foundation/deeplinks/blob/66e9e4f655994aaa1c630533d9afc15475990bf3/tests/sync-handlers.ts#L1241-L1268

# Error
```
ApolloError: Success! Handler is called

at new ApolloError (node_modules/@apollo/client/errors/index.js:29:28)
at node_modules/@apollo/client/core/QueryManager.js:96:47
at both (node_modules/@apollo/client/utilities/observables/asyncMap.js:16:53)
at node_modules/@apollo/client/utilities/observables/asyncMap.js:9:72
at Object.then (node_modules/@apollo/client/utilities/observables/asyncMap.js:9:24)
at Object.next (node_modules/@apollo/client/utilities/observables/asyncMap.js:17:49)
at notifySubscription (node_modules/zen-observable/lib/Observable.js:135:18)
at onNotify (node_modules/zen-observable/lib/Observable.js:179:3)
at SubscriptionObserver.next (node_modules/zen-observable/lib/Observable.js:235:7)
```

# Expected
Error is thrown from deep.insert therefore try-catch block catches it

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.